Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Improvements #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Minor Improvements #2

wants to merge 2 commits into from

Conversation

fgrsnau
Copy link
Member

@fgrsnau fgrsnau commented Nov 11, 2017

Adds ### THIS FILE IS MANAGED BY ANSIBLE -- DO NOT EDIT! ### to all of the files.

Sets /etc/mailname to mta_override_hostname or inventory_hostname (if the former is not specified; the same logic is used in posfix's main.cf).

@lukasjuhrich
Copy link

Happy birthday, dear pull request! :-) 🎂

@@ -1,3 +1,5 @@
### THIS FILE IS MANAGED BY ANSIBLE -- DO NOT EDIT! ###

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that already done in our ansible repos? I remember the header looking like {{ ansible_managed }}.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does that only cover ansible.git, but not the ansible-mta submodule?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, I would also vote for {{ ansible_managed }}. There are two reason for not using it:

  1. It only works in templates and not in static files.
  2. All other roles in our ansible repo use this static line. I just copied it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants